ArnavBalyan commented on PR #4621:
URL: https://github.com/apache/polaris/pull/4621#issuecomment-4638309006
> Thanks for your contribution, @ArnavBalyan !
>
> Unfortunately, we seem to have opened a can or worms with this PR and
#3716 😅 ... more specific comment below.
- Hi @dimas-b thank you so much for taking a look! I did some more
investigations and found the system behaviour was buggy have raised #4629 to
fix it.
- Further verified that Hibernate validation is working well, the warning
was shown due to hibernator proxy being unable to instrument static methods.
- To fix it, for now I've updated the rest api spec to do explicit
validation since hibernate won't be able to cover static method. Further added
UT to both paths to ensure we can verify the validation indeed works. Would
love to know what you think thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
