ArnavBalyan commented on PR #4621: URL: https://github.com/apache/polaris/pull/4621#issuecomment-4700146299
> Why did you close this PR, @ArnavBalyan ? Don't we want to fix #3716 ? > > My last comment was only about adding explicit calls to the validator. Other mustache pattern changes LGTM 👍 Hi @dimas thanks so much, I think the best we could do is remove the valid from builder since the validation is already happening through params, I've updated the PR and removed the valid from builder thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
