venkateshwaracholan commented on code in PR #4602: URL: https://github.com/apache/polaris/pull/4602#discussion_r3370061422
########## persistence/relational-jdbc/src/test/java/org/apache/polaris/persistence/relational/jdbc/AtomicMetastoreManagerWithJdbcBasePersistenceImplPostgresSchemaIT.java: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.persistence.relational.jdbc; + +import static org.apache.polaris.containerspec.ContainerSpecHelper.containerSpecHelper; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.stream.Stream; +import javax.sql.DataSource; +import org.apache.polaris.test.commons.PostgresRelationalJdbcLifeCycleManagement; +import org.junit.jupiter.params.Parameter; +import org.junit.jupiter.params.ParameterizedClass; +import org.junit.jupiter.params.provider.MethodSource; +import org.postgresql.ds.PGSimpleDataSource; +import org.testcontainers.junit.jupiter.Container; +import org.testcontainers.junit.jupiter.Testcontainers; +import org.testcontainers.postgresql.PostgreSQLContainer; + +/** + * Runs {@link org.apache.polaris.core.persistence.BasePolarisMetaStoreManagerTest} integration + * tests against every PostgreSQL schema version on the classpath. + */ +@Testcontainers +@ParameterizedClass +@MethodSource("schemaVersions") +public class AtomicMetastoreManagerWithJdbcBasePersistenceImplPostgresSchemaIT + extends AtomicMetastoreManagerWithJdbcBasePersistenceImplTest { + + @Container + private static final PostgreSQLContainer POSTGRES = + new PostgreSQLContainer( + containerSpecHelper("postgres", PostgresRelationalJdbcLifeCycleManagement.class) + .dockerImageName(null) + .asCompatibleSubstituteFor("postgres")); + + @Parameter int schemaVersion; + + private DataSource dataSource; + + static Stream<Integer> schemaVersions() { + return SchemaVersions.discoverAsStream(DatabaseType.POSTGRES); + } + + @Override + protected DatabaseType databaseType() { + return DatabaseType.POSTGRES; + } + + @Override + public int schemaVersion() { + return schemaVersion; + } + + @Override + protected DataSource createDataSource() { + if (dataSource == null) { + dataSource = createPostgresDataSource(schemaVersion()); + } + return dataSource; + } + + private static DataSource createPostgresDataSource(int schemaVersion) { + String databaseName = "polaris_schema_v" + schemaVersion; + createDatabaseIfNotExists(databaseName); + + PGSimpleDataSource postgresDataSource = new PGSimpleDataSource(); + postgresDataSource.setURL(jdbcUrlForDatabase(databaseName)); + postgresDataSource.setUser(POSTGRES.getUsername()); + postgresDataSource.setPassword(POSTGRES.getPassword()); + return postgresDataSource; + } + + private static void createDatabaseIfNotExists(String databaseName) { + try (Connection connection = + DriverManager.getConnection( + POSTGRES.getJdbcUrl(), POSTGRES.getUsername(), POSTGRES.getPassword()); + Statement statement = connection.createStatement()) { + statement.execute("CREATE DATABASE " + databaseName); + } catch (SQLException e) { + if (!"42P04".equals(e.getSQLState())) { Review Comment: Added a comment explaining that 42P04 is PostgreSQL's duplicate_database error and is expected when the schema database already exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
