dimas-b commented on code in PR #4602:
URL: https://github.com/apache/polaris/pull/4602#discussion_r3390378777
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisBaseEntity.java:
##########
@@ -343,8 +343,8 @@ public boolean equals(Object o) {
&& toPurgeTimestamp == that.toPurgeTimestamp
&& lastUpdateTimestamp == that.lastUpdateTimestamp
&& grantRecordsVersion == that.grantRecordsVersion
- && Objects.equals(properties, that.properties)
- && Objects.equals(internalProperties, that.internalProperties);
+ && Objects.equals(getPropertiesAsMap(), that.getPropertiesAsMap())
+ && Objects.equals(getInternalPropertiesAsMap(),
that.getInternalPropertiesAsMap());
Review Comment:
As discussed earlier in this PR, I think this change is correct.
However, since it is a major change in `polaris-core` code, would you mind
sending a email to the `dev` ML about this for general community awareness?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
