adutra commented on code in PR #4136: URL: https://github.com/apache/polaris/pull/4136#discussion_r3374203586
########## polaris-core/src/main/java/org/apache/polaris/core/catalog/LocalIcebergCatalog.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.catalog; + +import java.util.Map; +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.SupportsNamespaces; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.catalog.ViewCatalog; +import org.apache.polaris.core.persistence.PolarisMetaStoreManager; +import org.apache.polaris.core.persistence.pagination.Page; +import org.apache.polaris.core.persistence.pagination.PageToken; + +/** Base interface for local Polaris Catalogs dealing with Iceberg tables. */ +public interface LocalIcebergCatalog extends Catalog, ViewCatalog, SupportsNamespaces { Review Comment: Why not extend `SupportsNotifications`? ########## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandlerFactory.java: ########## @@ -54,7 +53,7 @@ public class IcebergCatalogHandlerFactory { @Inject PolarisAuthorizer authorizer; @Inject ReservedProperties reservedProperties; @Inject CatalogHandlerUtils catalogHandlerUtils; - @Inject @Any Instance<FederatedCatalogFactory> federatedCatalogFactories; + @Inject @Any ResolvingFederatedCatalogFactory federatedCatalogFactory; Review Comment: You probably don't need the `@Any` annotation anymore. ########## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ########## @@ -152,7 +152,7 @@ /** Defines the relationship between PolarisEntities and Iceberg's business logic. */ public class IcebergCatalog extends BaseMetastoreViewCatalog Review Comment: Since we are here, could we consider renaming `IcebergCatalog` to `DefaultLocalIcebergCatalog` or `PolarisLocalIcebergCatalog`? I always found this name confusing because it is not immediately clear that this is a local catalog (as opposed to a federated one), and "Iceberg" tends to indicate that it's not a Polaris-specific component, when in fact it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
