flyrain commented on code in PR #4136: URL: https://github.com/apache/polaris/pull/4136#discussion_r3384042280
########## polaris-core/src/main/java/org/apache/polaris/core/catalog/LocalIcebergCatalog.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.catalog; + +import java.util.Map; +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.SupportsNamespaces; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.catalog.ViewCatalog; +import org.apache.polaris.core.persistence.PolarisMetaStoreManager; +import org.apache.polaris.core.persistence.pagination.Page; +import org.apache.polaris.core.persistence.pagination.PageToken; + +/** Base interface for local Polaris Catalogs dealing with Iceberg tables. */ +public interface LocalIcebergCatalog extends Catalog, ViewCatalog, SupportsNamespaces { Review Comment: option 1. Can we position it as a maker interface, so that it doesn't extend any other interfaces? option 2. Move `SupportsNotifications` to `core`, I do think moving most interfaces to core is a good practice now, given the current convention we have. For example, these 3 related interfaces are in the core: `FederatedCatalogFactory`, `GenericTableCatalog`, and `LocalCatalogFactory`. And a bunch of other interfaces like `PolarisAuthorizer` live in core as well. So that the Polaris core serving as a SPI module for different implementations. I don't understand why this interface cannot be in the core. If we do have reasons, we could create a new module like service api or service core in the future to move certain interfaces out of `polaris-core`. I don't think it's necessary but I'm open to discussions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
