sririshindra commented on PR #4225: URL: https://github.com/apache/polaris/pull/4225#issuecomment-4661869834
> Hi @sririshindra, thank you for the thorough work on this! I also appreciate the patience you've shown in addressing all the comments and reviewer feedback. > > I believe this PR introduces significant enhancements, most notably that the persistence listener can now handle all event types. Given that it has already received other approvals, I suggest we proceed with the merge, as it represents a clear improvement over our current state. > > That said, as mentioned in my comments, the design still feels slightly rigid and doesn't yet fully capitalize on the new `EventSanitizer` idea. My long-term goal is to reach a state where sanitizers and listeners form a fully configurable event delivery pipeline that doesn't require rebuilding Polaris. I think that CDI and the Vert.x event bus can deliver that. > > Thanks again for the hard work; we can address my design ideas in subsequent follow-up tasks. Thank you @adutra for your thorough review. You mentioned we can merge this PR and address your design ideas in subsequent follow-ups. That sounds like a good plan to me. Is there any change that you would like me to do in this PR itself and not a follow-up? If not, can you approve this PR so that it can get merged and I will address your comments in a follow-up? Does that work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
