gh-yzou commented on code in PR #4588:
URL: https://github.com/apache/polaris/pull/4588#discussion_r3384728561
##########
.github/workflows/ci.yml:
##########
@@ -462,12 +462,6 @@ jobs:
AWS_SECRET_ACCESS_KEY: ${{secrets.AWS_SECRET_ACCESS_KEY}} # zizmor:
ignore[secrets-outside-env]
S3_TEST_BACKEND: ${{ matrix.s3-backend }}
run: docker compose --profile ${{ matrix.s3-backend }} -f
regtests/docker-compose.yml up --build --exit-code-from regtest
- - name: Spark Plugin Regression Test
- # NOTE: the regression test runs with spark 3.5.6 and scala 2.12 in
Java 17. We also have integration
- # tests runs with the existing gradle.yml, which only runs on Java 21.
Since spark Java compatibility
- # for 3.5 is 8, 11, and 17, we should run spark client with those
compatible java versions.
- # TODO: add separate spark client CI and run with Java 8, 11 and 17.
- run: docker compose -f plugins/spark/v3.5/regtests/docker-compose.yml
up --build --exit-code-from regtest
Review Comment:
Hi @MonkeyCanCode i see the new test now doesn't have any delta, hudi
related test anymore. However, for user who is using hudi and delta, different
packages are needed. with this change, we are now missing the coverage for hudi
and delta packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
