dimas-b commented on code in PR #4708:
URL: https://github.com/apache/polaris/pull/4708#discussion_r3399802032
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ServiceProducers.java:
##########
@@ -149,6 +149,12 @@ public CallContext polarisCallContext(
return new PolarisCallContext(realmContext, metaStore, metricsPersistence,
configurationSource);
}
+ @Produces
+ @RequestScoped
+ public MetricsPersistence metricsPersistence(CallContext callContext) {
+ return callContext.getPolarisCallContext().getMetricsPersistence();
Review Comment:
#4655 implies avoiding indirection via `CallContext` 😉
Would you mind taking this one step further and removing
`MetricsPersistence` from `CallContext`? I do not think there is any reason for
it to be there after this PR.
If you prefer that can be done as a separate follow-up PR. Current change is
good and self-contained 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
