bowsii commented on PR #4708:
URL: https://github.com/apache/polaris/pull/4708#issuecomment-4697880690
Thanks @dimas-b!
I've addressed the remaining comments:
* Confirmed `writeScanMetrics` and `writeCommitMetrics` had no callers after
the refactor and removed `PolarisMetricsManager` entirely.
* Removed the corresponding `PolarisMetricsManager` references and stale
javadocs.
* Simplified the `MetricsPersistence` producer to call
`getOrCreateMetricsPersistence(realmContext)` directly.
* Verified with:
* `./gradlew format`
* `./gradlew :polaris-core:check`
* `./gradlew :polaris-runtime-service:test --tests
"org.apache.polaris.service.reporting.PersistingMetricsReporterTest"`
Please take another look when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
