Copilot commented on code in PR #4750:
URL: https://github.com/apache/polaris/pull/4750#discussion_r3408961018
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java:
##########
@@ -1296,6 +1297,18 @@ public void
testRenameTablePrivilegesOnWrongSourceOrDestination() {
adminService.grantPrivilegeOnNamespaceToRole(
CATALOG_NAME, CATALOG_ROLE1, NS2, PolarisPrivilege.TABLE_CREATE));
newHandler().renameTable(rename2);
+
+ // Verify that renaming a non-existent source reports the source
identifier in the error
+ TableIdentifier nonExistentSource = TableIdentifier.of(NS1,
"no_such_table");
+ TableIdentifier destination = TableIdentifier.of(NS1AA, "another");
+ RenameTableRequest badRename =
+ RenameTableRequest.builder()
+ .withSource(nonExistentSource)
+ .withDestination(destination)
+ .build();
+ Assertions.assertThatThrownBy(() -> newHandler().renameTable(badRename))
+ .isInstanceOf(NoSuchTableException.class)
+ .hasMessageContaining(nonExistentSource.toString());
Review Comment:
Asserting on `nonExistentSource.toString()` makes the test depend on
Iceberg’s exact `TableIdentifier#toString()` formatting. To reduce brittleness
while still validating the intent, consider asserting on stable components
(e.g., namespace and table name substrings, or just the table name) rather than
the full `toString()` output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
