ayushtkn commented on code in PR #4750:
URL: https://github.com/apache/polaris/pull/4750#discussion_r3414557457
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java:
##########
@@ -1296,6 +1297,18 @@ public void
testRenameTablePrivilegesOnWrongSourceOrDestination() {
adminService.grantPrivilegeOnNamespaceToRole(
CATALOG_NAME, CATALOG_ROLE1, NS2, PolarisPrivilege.TABLE_CREATE));
newHandler().renameTable(rename2);
+
+ // Verify that renaming a non-existent source reports the source
identifier in the error
+ TableIdentifier nonExistentSource = TableIdentifier.of(NS1,
"no_such_table");
+ TableIdentifier destination = TableIdentifier.of(NS1AA, "another");
+ RenameTableRequest badRename =
Review Comment:
Thnax @adutra for the review. I couldn't find any relevant place, this was
the nearest `testRenameTablePrivilegesOnWrongSourceOrDestination`
Do you have any suggestions around it? or if the change can go without a
test, in that case I can drop the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
