dimas-b commented on code in PR #4659: URL: https://github.com/apache/polaris/pull/4659#discussion_r3414868982
########## runtime/service/src/main/java/org/apache/polaris/service/idempotency/NoOpIdempotencyStore.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.idempotency; + +import java.time.Instant; +import java.util.Optional; +import java.util.UUID; +import org.apache.polaris.core.entity.IdempotencyRecord; +import org.apache.polaris.core.persistence.IdempotencyStore; + +/** + * Inert {@link IdempotencyStore} produced when idempotency is disabled. Handlers short-circuit on + * {@link IdempotencyHandlerSupport#isEnabled()} and never touch the store, so every method here + * fails fast: reaching one means a code path tried to use the store while the feature is off. + */ +final class NoOpIdempotencyStore implements IdempotencyStore { + + static final NoOpIdempotencyStore INSTANCE = new NoOpIdempotencyStore(); + + private NoOpIdempotencyStore() {} + + @Override + public Optional<IdempotencyRecord> load(UUID idempotencyKey) { + throw disabled(); Review Comment: nit: technically this is a `DisabledIdempotencyStore`, I'd expect a "no-op" store to simply ignore the call. The code is fine from my POV, this is just a naming concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
