obelix74 commented on code in PR #4115:
URL: https://github.com/apache/polaris/pull/4115#discussion_r3416286853
##########
runtime/service/build.gradle.kts:
##########
@@ -32,6 +32,7 @@ dependencies {
implementation(project(":polaris-api-catalog-service"))
runtimeOnly(project(":polaris-relational-jdbc"))
+ runtimeOnly(project(":polaris-extensions-metrics-reports"))
Review Comment:
Correction to my previous comment: I've had to revert this back to
`runtimeOnly`. The integration tests in this module (e.g. `RestCatalogFileIT`)
are annotated with `@QuarkusIntegrationTest`, which packages and starts the
application as a fully built artifact using the main `runtimeClasspath`.
`testRuntimeOnly` excludes the dep from that packaged app, so
`LoggingMetricsReporter` and `NoOpMetricsReporter` aren't discovered by CDI at
startup, causing `testSendMetricsReport()` to fail with a non-204 response.
The `runtimeOnly` dep is needed here to support these integration tests.
`runtime/server` already has an explicit `runtimeOnly` dep on the same module,
so this is consistent — the duplicate is harmless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
