obelix74 commented on code in PR #4115:
URL: https://github.com/apache/polaris/pull/4115#discussion_r3416892067
##########
runtime/service/build.gradle.kts:
##########
@@ -32,6 +32,7 @@ dependencies {
implementation(project(":polaris-api-catalog-service"))
runtimeOnly(project(":polaris-relational-jdbc"))
+ runtimeOnly(project(":polaris-extensions-metrics-reports"))
Review Comment:
Good catch — it was leaking. Fixed by making the CDI producer resilient
instead: if no `IcebergMetricsReporter` is found for the configured type, it
now logs a warning and falls back to a no-op rather than hard-failing with
`UnsatisfiedResolutionException`. This lets `runtime/service` drop the
`runtimeOnly` dep on the impl module entirely.
For real deployments `runtime/server` retains its own explicit `runtimeOnly`
dep on `polaris-extensions-metrics-reports`, so `LoggingMetricsReporter` is
still present in production builds. For integration tests in `runtime/service`
(`@QuarkusIntegrationTest` packages the app from `runtimeClasspath`), the no-op
fallback satisfies CDI and the metrics endpoint still returns 204.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
