dimas-b commented on code in PR #4770:
URL: https://github.com/apache/polaris/pull/4770#discussion_r3417364247
##########
client/python/apache_polaris/cli/command/profiles.py:
##########
@@ -117,12 +116,15 @@ def _update_profile(self, name: str) -> None:
current_port = profiles[name].get("port")
current_realm = profiles[name].get(Arguments.REALM)
current_header = profiles[name].get(Arguments.HEADER)
+ masked_secret = format_profile_for_display(profiles[name]).get(
+ "client_secret"
+ )
client_id = (
input(f"Polaris Client ID [{current_client_id}]: ") or
current_client_id
)
client_secret = (
- input(f"Polaris Client Secret [{current_client_secret}]: ")
+ getpass(f"Polaris Client Secret [{masked_secret}]: ")
Review Comment:
`masked_secret` always has the same value (logically), could we use a
simpler (static) message here? e.g. `Enter Polaris Client Secret (empty to
reuse previous value)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
