MonkeyCanCode commented on PR #4770:
URL: https://github.com/apache/polaris/pull/4770#issuecomment-4714291597
One thing I am not sure about is does it really makes sense to use getpass.
For example, the reason on why I didn't do so earlier was to matching to how
`aws configure` works:
```
➜ ~ aws configure
AWS Access Key ID [None]: user
AWS Secret Access Key [None]: pass
Default region name [None]:
```
With aws cli, the secret access key is plain text when you tried to create
one. Then when tried to access, it will show last 4 characters instead of full
`*`:
```
➜ ~ aws configure list
Name Value Type Location
---- ----- ---- --------
profile <not set> None None
access_key ****************user shared-credentials-file
secret_key ****************pass shared-credentials-file
```
This is more preference IMO. Both will work but do we want to match to how
AWS cli is handling those or we can go with our own implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
