dimas-b commented on code in PR #4795:
URL: https://github.com/apache/polaris/pull/4795#discussion_r3422825869
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -1125,7 +1125,7 @@ private boolean handleInheritablePolicy(
datasourceOperations.execute(connection, updateQuery);
} else {
// record doesn't exist do an insert.
- datasourceOperations.executeUpdate(insertQuery);
+ datasourceOperations.execute(connection, insertQuery);
Review Comment:
Good catch, @vigneshio !
This change makes sense. However, the select on line 1086
(`loadPoliciesOnTargetByType()`) should probably be done on the same connection
too.... WDYT?
CC: @singhpk234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
