dimas-b commented on code in PR #4795:
URL: https://github.com/apache/polaris/pull/4795#discussion_r3424443536
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -1125,7 +1125,7 @@ private boolean handleInheritablePolicy(
datasourceOperations.execute(connection, updateQuery);
} else {
// record doesn't exist do an insert.
- datasourceOperations.executeUpdate(insertQuery);
+ datasourceOperations.execute(connection, insertQuery);
Review Comment:
Yes, this PR is net positive as it stands. Follow-up is fine for the select.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
