adutra commented on code in PR #4812:
URL: https://github.com/apache/polaris/pull/4812#discussion_r3431117534
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/RelationalJdbcConfiguration.java:
##########
@@ -21,18 +21,21 @@
import java.util.Optional;
public interface RelationalJdbcConfiguration {
- // max retries before giving up
+ /** The maximum number of retries before giving up the operation. */
Optional<Integer> maxRetries();
- // max retry duration
+ /** The maximum retry duration in milliseconds. */
Optional<Long> maxDurationInMs();
- // initial delay
+ /** The initial retry delay. */
Optional<Long> initialDelayInMs();
/**
* Explicitly configured database type. If not specified, the database type
will be inferred from
* the JDBC connection metadata. Supported values: "postgresql",
"cockroachdb", "h2"
*/
Optional<String> databaseType();
+
+ /** The datasource name to use. Required. */
+ String dataSource();
Review Comment:
Note: the datasource name is distinct from the database type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
