adutra commented on code in PR #4812:
URL: https://github.com/apache/polaris/pull/4812#discussion_r3431171222
##########
runtime/test-common/src/main/java/org/apache/polaris/test/commons/PostgresRelationalJdbcLifeCycleManagement.java:
##########
@@ -61,16 +61,12 @@ public Map<String, String> start() {
return Map.ofEntries(
Map.entry("polaris.persistence.type", "relational-jdbc"),
Map.entry("polaris.persistence.relational.jdbc.max-retries", "2"),
- Map.entry("quarkus.datasource.db-kind", "postgresql"),
- Map.entry("quarkus.datasource.jdbc.url", postgres.getJdbcUrl()),
- Map.entry("quarkus.datasource.username", postgres.getUsername()),
- Map.entry("quarkus.datasource.password", postgres.getPassword()),
- Map.entry("quarkus.datasource.jdbc.initial-size", "10"),
- // Configure metrics named datasource to use the same PostgreSQL
instance
Review Comment:
These "metric datasource" settings came as a surprise to me. I think it's an
oversight; they were introduced by #3385 – but that PR does not implement
separate datasources in its final form. Multiple datasources were attempted in
#3960 (but it was closed without merging).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
