dimas-b opened a new pull request, #4866:
URL: https://github.com/apache/polaris/pull/4866
This is a rebased version of #4708 from @bowsii (plus conflict resolutions)
Fixes #4655
1. Added a CDI producer for MetricsPersistence in ServiceProducers.
2. Removed CallContext dependency from PersistingMetricsReporter.
3. Removed PolarisMetaStoreManager dependency from
PersistingMetricsReporter.
4. Injected MetricsPersistence directly into
PersistingMetricsReporter.
5. Replaced:
metaStoreManager.writeScanMetrics(...)
with:
metricsPersistence.writeScanReport(...)
6. Replaced:
metaStoreManager.writeCommitMetrics(...)
with:
metricsPersistence.writeCommitReport(...)
7. Updated Javadocs to reflect direct MetricsPersistence usage.
8. Refactored PersistingMetricsReporterTest:
- Removed CallContext mocks.
- Removed PolarisMetaStoreManager mocks.
- Added MetricsPersistence mock.
- Updated verifications to use
writeScanReport() and writeCommitReport().
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected])
- [ ] ๐ Clearly explained why the changes are needed, or linked related
issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and
explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
