nandorKollar commented on code in PR #4850:
URL: https://github.com/apache/polaris/pull/4850#discussion_r3461495378
##########
runtime/service/src/main/java/org/apache/polaris/service/task/BatchFileCleanupTaskHandler.java:
##########
@@ -77,17 +77,12 @@ public boolean handleTask(TaskEntity task, CallContext
callContext) {
missingFiles.size());
}
- // Schedule the deletion for each file asynchronously
- List<CompletableFuture<Void>> deleteFutures =
- validFiles.stream()
- .map(file -> super.tryDelete(tableId, authorizedFileIO, null,
file, null, 1))
- .toList();
+ CompletableFuture<Void> deleteFutures =
+ tryDelete(
+ tableId, authorizedFileIO, validFiles,
cleanupTask.type().getValue(), true, null, 1);
Review Comment:
Since, as you mentioned, Polaris currently supports only S3, GCS, and Azure,
I'm wondering whether it makes sense to prepare for anything that doesn't
support `SupportsBulkOperations` today. Also, is `fileIO` pluggable in Polaris?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
