dimas-b commented on code in PR #4850:
URL: https://github.com/apache/polaris/pull/4850#discussion_r3469230255
##########
runtime/service/src/main/java/org/apache/polaris/service/task/BatchFileCleanupTaskHandler.java:
##########
@@ -77,17 +77,12 @@ public boolean handleTask(TaskEntity task, CallContext
callContext) {
missingFiles.size());
}
- // Schedule the deletion for each file asynchronously
- List<CompletableFuture<Void>> deleteFutures =
- validFiles.stream()
- .map(file -> super.tryDelete(tableId, authorizedFileIO, null,
file, null, 1))
- .toList();
+ CompletableFuture<Void> deleteFutures =
+ tryDelete(
+ tableId, authorizedFileIO, validFiles,
cleanupTask.type().getValue(), true, null, 1);
Review Comment:
As of Iceberg 1.11.0 (current in Polaris ATM), `SupportsBulkOperations` is
implemented by `ResolvingFileIO`, `S3FileIO`, `ADLSFileIO`, `GCSFileIO` (and
`HadoopFileIO`).
I think this covers the full list of supported storage types in Polaris ATM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
