obelix74 commented on PR #4115:
URL: https://github.com/apache/polaris/pull/4115#issuecomment-4814126214
@dimas-b
This PR removes the existing durable JDBC metrics persistence path in commit:
#0385f125d refactor(metrics): fix SPI layering — move IcebergMetricsReporter
to polaris-core, remove MetricsPersistence from BasePersistence
That commit removes metrics persistence methods from:
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java
Specifically, it removes:
• writeScanReport
• writeCommitReport
• listScanReports
• listCommitReports
• JDBC metrics insert/query helpers
• metrics pagination/query code
It also removes related durable-path code from:
•
runtime/service/src/main/java/org/apache/polaris/service/reporting/PersistingMetricsReporter.java
•
polaris-core/src/main/java/org/apache/polaris/core/persistence/metrics/MetricsPersistence.java
•
polaris-core/src/main/java/org/apache/polaris/core/metrics/iceberg/MetricsRecordConverter.java
• JDBC metrics model/test files under persistence/relational-jdbc
The reason given in the commit is architecture review feedback: durable
metrics persistence was leaking through BasePersistence into every metastore
backend. PR1 was narrowed to the API/SPI and non-durable reporters only, while
durable JDBC persistence was deferred to PR2 as a separate extension module.
Warning: if PR1 is merged without PR2, this is a temporary regression.
polaris.iceberg-metrics.reporting.type=persisting will no longer work, metrics
will not be written to JDBC storage, and the Metrics Reports read API will
return HTTP 501 until PR2 adds
extensions/metrics-reports/persistence/relational-jdbc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
