dimas-b commented on code in PR #4115: URL: https://github.com/apache/polaris/pull/4115#discussion_r3468677372
########## polaris-core/src/main/java/org/apache/polaris/core/metrics/IcebergMetricsReporter.java: ########## @@ -16,38 +16,33 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.polaris.service.reporting; +package org.apache.polaris.core.metrics; Review Comment: The current state of the PR LGTM :+1: @flyingImer : I propose merging this PR and continuing the discussion about SPI interface locations on `dev`. The current layout does not impose any restrictions on downstream use and permits pluggable SPI implementation. Related `dev` thread: https://lists.apache.org/thread/d9dj3w8ktwdn6w27z7tvvgkljgw3n43b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
