MonkeyCanCode commented on code in PR #234:
URL: https://github.com/apache/polaris-tools/pull/234#discussion_r3510224977
##########
console/helm/templates/httproute.yaml:
##########
@@ -24,27 +25,23 @@ apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
name: {{ $fullName }}
+ namespace: {{ .Release.Namespace }}
labels:
{{- include "polaris-console.labels" . | nindent 4 }}
{{- with .Values.httproute.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
- hostnames: {{ .Values.httproute.hosts }}
+ hostnames: {{ .Values.httproute.hosts | toJson }}
parentRefs:
- - name: {{ .Values.httproute.gatewayName}}
- group: {{ .Values.httproute.gatewayGroup }}
Review Comment:
Same as above, matched to polaris one
(https://github.com/apache/polaris/blob/main/helm/polaris/templates/httproute.yaml#L36).
If not blocker, lets do refactor in a different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
