MonkeyCanCode commented on code in PR #234:
URL: https://github.com/apache/polaris-tools/pull/234#discussion_r3510252018
##########
console/Makefile:
##########
@@ -89,3 +89,143 @@ lint-fix: format-fix ## Fix linting issues in the console
project
@echo "--- Fixing linting issues in the console project ---"
@npm run lint -- --fix
@echo "--- Linting issues in the console project fixed ---"
+
+##@ Helm
+
+.PHONY: helm
+helm: helm-schema-generate helm-lint helm-unittest ## Run most Helm targets
(schema, unittest, and lint)
+
+helm-install-plugins: DEPENDENCIES := helm
+.PHONY: helm-install-plugins
+helm-install-plugins: check-dependencies ## Install required Helm plugins
(unittest, schema)
+ @echo "--- Installing Helm plugins ---"
+ @HELM_MAJOR_VERSION=$$(helm version --short | sed 's/^v//' | cut -d.
-f1); \
+ if [ "$$HELM_MAJOR_VERSION" -ge 4 ] 2>/dev/null; then \
+ HELM_PLUGIN_FLAGS="--verify=false"; \
Review Comment:
This is from
https://github.com/apache/polaris/commit/f7bb2bbff716afcdc45db5589ba0381825c376c6
when we add this long time back. The reason is due to
https://github.com/helm-unittest/helm-unittest/issues/777.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
