markmckeown commented on PR #4923: URL: https://github.com/apache/polaris/pull/4923#issuecomment-4878105002
Pushed another version of the patch based on feedback (thanks). * Added tests that use KafkaContainer testcontainer. * Excluded zstd-jni jar * General code fixes per feedback. * Moved the JSON generation to a helper class. This could be used in AwsCloudWatchEventListener, I have a patch for this and the associated tests pass without change except for the AwsCloudWatchEventListener object construction, but now more information is being sent than previously and I am not sure if that would break anything. I also had a look PolarisPersistenceEventListener and was wondering if the Kafka listener should inherit from this and implement processEvent to send to Kafka, this would mean serializing EventEntity to JSON. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
