adutra commented on code in PR #4962:
URL: https://github.com/apache/polaris/pull/4962#discussion_r3519760278
##########
runtime/service/src/main/java/org/apache/polaris/service/task/FileCleanupTaskHandler.java:
##########
@@ -37,6 +36,9 @@
*
* <p>Subclasses must implement {@link #canHandleTask(TaskEntity)} and {@link
* #handleTask(TaskEntity, CallContext)} to define task-specific handling
logic.
+ *
+ * <p>handleTask should return normally on success (task will be dropped) and
throw on failure (to
Review Comment:
nit: this comment would be better placed at the `handleTask` method level.
##########
runtime/service/src/main/java/org/apache/polaris/service/task/ManifestFileCleanupTaskHandler.java:
##########
@@ -118,8 +118,7 @@ private boolean cleanUpManifestFile(
} catch (IOException e) {
// Catches from ManifestFiles.read() (resource creation), from inside
the block
// (e.g. manifest iteration), or from close(). We throw (wrapping) so
the original
- // failure propagates and TaskExecutorImpl's retry path is used.
(handleTask returns
- // boolean and cannot declare a checked throws IOException.)
+ // failure propagates and the retry path is used. (handleTask is now
void.)
LOGGER.error("Failed to process manifest reader for {}",
manifestFile.path(), e);
throw new RuntimeException(e);
Review Comment:
nit:
```suggestion
throw new UncheckedIOException(e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
