vigneshio commented on code in PR #4962:
URL: https://github.com/apache/polaris/pull/4962#discussion_r3551646612
##########
runtime/service/src/test/java/org/apache/polaris/service/task/TaskExecutorImplTest.java:
##########
@@ -224,8 +223,7 @@ public boolean handleTask(TaskEntity task, CallContext
callContext) {
PolarisEventMetadata.builder().realmId(realm).build(),
1))
.isInstanceOf(RuntimeException.class)
- .hasMessageContaining("Task handler returned false")
- .hasMessageContaining(String.valueOf(taskEntity.getId()));
Review Comment:
@dimas-b Thanks for flagging that - the task ID is still in the message. It
includes both the task type and the entity ID, and `TaskExecutorImplTest`
asserts both. The "Task handler returned false" snippet was from an earlier
iteration; that path is gone since we changed the return type to void.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
