dimas-b commented on code in PR #4926: URL: https://github.com/apache/polaris/pull/4926#discussion_r3546237864
########## runtime/service-spi/src/main/java/org/apache/polaris/service/spi/CatalogConfigEndpointContributor.java: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.rest; + +import java.util.Set; +import org.apache.iceberg.rest.Endpoint; + +/** Contributes endpoints advertised in catalog configuration responses. */ +@FunctionalInterface +public interface CatalogConfigEndpointContributor { + Set<Endpoint> endpoints(); Review Comment: I do not think there is any "current convention" here :shrug: Having existing code in the repo does not imply a convention. In many cases things are added to `polaris-core` out of simplicity, but it does not mean that it is the best layout. Putting irrelevant classes into `polaris-core` dilutes the meaning of that module and increases coupling, which will complicate future refactorings as it is much harder to move code away from a module than to merge two distinct modules. Adding a new module is not a risky change. It is imported where necessary and does not affect modules where it is not imported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
