adam-christian-software commented on code in PR #4926: URL: https://github.com/apache/polaris/pull/4926#discussion_r3546471868
########## polaris-core/src/main/java/org/apache/polaris/core/rest/CatalogConfigEndpointContributor.java: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.rest; + +import java.util.Set; +import org.apache.iceberg.rest.Endpoint; + +/** Contributes endpoints advertised in catalog configuration responses. */ +@FunctionalInterface +public interface CatalogConfigEndpointContributor { + Set<Endpoint> endpoints(); Review Comment: @dimas-b - I agree with you that I don't believe that there is any "current convention" or standard with SPIs. From my understanding, I think that EJ is trying to come to a proposal on SPIs, but currently, "polaris-core being the SPI" is far from an agreed-upon standard in the community. Polaris-core existed when the code was donated to Apache during incubation and it still needs to be discussed as a community on how we want to handle service provider integrations. I also agree that the CatalogConfigEndpointContributor is NOT a `polaris-core` concept in the typical sense. Nothing in Polaris-Core depends on this functionality and it is more related to the REST API service layer than anything else. With all of that said, having CatalogConfigEndpointContributor in `polaris-core` seems like an alright approach to unblock this PR while the larger SPI conversations are ongoing. Then, we can revisit this to ensure it is properly in the right place. Are you OK with that at this point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
