dimas-b commented on code in PR #4939:
URL: https://github.com/apache/polaris/pull/4939#discussion_r3575174400
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/LocalIcebergCatalog.java:
##########
@@ -1218,6 +1218,37 @@ void validateStagedTableCreate(TableIdentifier
tableIdentifier, TableMetadata ta
catalogEntity, tableIdentifier, resolvedNamespace, location,
storageLeafEntity));
}
+ /**
+ * Validates location overlap for an existing table whose locations changed.
Unlike {@link
+ * #validateStagedTableCreate}, this uses the parent (namespace) path for
resolution since the
+ * table already exists and its resolved path includes the table entity
itself.
+ */
+ void validateTableLocationUpdate(TableIdentifier tableIdentifier,
TableMetadata tableMetadata) {
+ PolarisResolvedPathWrapper resolvedTableEntities =
+ resolvedEntityView.getPassthroughResolvedPath(
Review Comment:
Thx - this check LGTM, but let's keep discussing the batch commit method
(separate thread).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
