sebbASF commented on pull request #517: URL: https://github.com/apache/incubator-ponymail/pull/517#issuecomment-679215118
I agree that the generator looks very promising. However, I think it has some issues that need to be solved. For example, the current implementation includes the lid override in the hash. The override is not an intrinsic part of the source message, so unless the same override is used when reloading, a different id will be generated. This is going to cause problems if lists are renamed. e.g. if one imports an archive for [email protected], re-importing using the lid '<[email protected]>' changes the ids even though it is for the same list. It is advisable to use the lid override, especially when importing older archives which may not have any list headers. It needs to be tested to see whether it properly distinguishes duplicates. Sometimes MTAs hiccup, and cause the same message to appear twice on a mailing list. These should have different ids. Does the generator work well with mails that don't have list headers? For example, aliases and older mail archives. Also the hash strength has yet to be decided; is the current length sufficient? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
