Humbedooh commented on pull request #517:
URL: 
https://github.com/apache/incubator-ponymail/pull/517#issuecomment-679282204


   As for `Does the generator work well with mails that don't have list 
headers?`, I see no indication that it would make any difference if a header is 
present or not. 
   
   The pibble length can be debated, but we have to balance the requirement of 
the administrators and that of the end users.
   The current length is good enough that random collisions are unlikely to 
happen (1:10^24 chance of that).
   It is short enough that people will use the permalinks and not use a URL 
shortener.
   I'm not knowledgeable enough to know about the precise preimage attack 
chances here. 
   
   I am however satisfied that this generator works as intended, and improves 
upon what we have to offer. If that means going from 16 bytes in the pibble to 
24, for added preimage security, I'd be okay with that. What I would dislike is 
doing a full length digest, as that discourages using permalinks in their raw 
form, which is counterproductive for permalinks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to