dimidd commented on issue #467: setup: move mappings to a separate file URL: https://github.com/apache/incubator-ponymail/pull/467#issuecomment-394145258 OK, I'll make a separate PR for whitespace fixes. Regarding comments, how about using YAML which does support one-line comments? I agree that the best option would be to add an optional flag `--mappings_file <my_mappings.yml>`, to override the default one. Some projects even force the user to customize, by providing only an example file, but I didn't wan't to break existing scripts and docs. In addition, `setup.py` is way trop long, and I believe that outsourcing the mappings would also improve readability.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
