[ 
https://issues.apache.org/jira/browse/RATIS-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222752#comment-17222752
 ] 

Tsz-wo Sze commented on RATIS-1115:
-----------------------------------

[~amaliujia], thanks for filing this JIRA.  We need to think about how to 
handle error case carefully.  In particular, how would the system recover from 
the error?

For RATIS-1104, we send an unsuccessful reply when the bytesWritten values are 
mismatched.  However, we should also think about how should the stream 
continues.  Or, we may close it and cleanup everything.  Currently, if 
bytesWritten values are mismatched, the system cannot recover from it.

It probably is a good idea to continue the error handling work in this JIRA.  
Let's have a design discussion.

[~yjxxtd], you probably want to join the discussion on error handling.

> NettyServerStreamRpc should handle duplicate headers
> ----------------------------------------------------
>
>                 Key: RATIS-1115
>                 URL: https://issues.apache.org/jira/browse/RATIS-1115
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>
> Current server does 
>  
> {code:java}
> if (Header) {    
>   streams.computeIfAbsent(request.getStreamId(), id ->createStream());
>   ...  
> }
> {code}
>  
>  
> It is possible that clients send multiple headers so the entry already 
> exists. We might choose to send a reply with error message without accepting 
> duplicated headers. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to