[ 
https://issues.apache.org/jira/browse/RATIS-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223991#comment-17223991
 ] 

Tsz-wo Sze commented on RATIS-1115:
-----------------------------------

This is a good start.

For any error cases, we should think about the following questions:
- How could this error happen?
- Should it be ignored? (e.g. received an unexpected packet.)
- Should it be retried?
- Should it fail the client?
- If it cannot be recovered (e.g. retried multiple times but still failed), how 
to cleanup?


> NettyServerStreamRpc should handle duplicate headers
> ----------------------------------------------------
>
>                 Key: RATIS-1115
>                 URL: https://issues.apache.org/jira/browse/RATIS-1115
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>
> Current server does 
>  
> {code:java}
> if (Header) {    
>   streams.computeIfAbsent(request.getStreamId(), id ->createStream());
>   ...  
> }
> {code}
>  
>  
> It is possible that clients send multiple headers so the entry already 
> exists. We might choose to send a reply with error message without accepting 
> duplicated headers. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to