szetszwo commented on a change in pull request #479:
URL: https://github.com/apache/ratis/pull/479#discussion_r648116323
##########
File path:
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
##########
@@ -51,6 +51,16 @@ static void setStorageDir(RaftProperties properties,
List<File> storageDir) {
setFiles(properties::setFiles, STORAGE_DIR_KEY, storageDir);
}
+ String STORAGE_SPACE_RESERVED_KEY = PREFIX + ".storage.space.reserved";
Review comment:
In the change below, it compares only the free spaces but not including
the occupied spaces.
```root.getFreeSpace() > spaceReserved;```
The picture actually is
|------------for server to consume---------|-- existing snapshots & log
files --|reserved |
So we cannot say that the space is reserved for snapshots. Reserved space
is more complicated to implement.
It seems that the amount of the space is the minimum required for starting a
server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
