guihecheng commented on a change in pull request #479:
URL: https://github.com/apache/ratis/pull/479#discussion_r648127289
##########
File path:
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
##########
@@ -51,6 +51,16 @@ static void setStorageDir(RaftProperties properties,
List<File> storageDir) {
setFiles(properties::setFiles, STORAGE_DIR_KEY, storageDir);
}
+ String STORAGE_SPACE_RESERVED_KEY = PREFIX + ".storage.space.reserved";
Review comment:
@szetszwo Ah, yeah, I agree with you, this should better be minRequired
space for a ratis storageDir.
So what about name it to '.storage.space.min.required' ?
(Reserved should be for other app on the same disk if there is any.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
