szetszwo commented on a change in pull request #560:
URL: https://github.com/apache/ratis/pull/560#discussion_r767458817



##########
File path: 
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java
##########
@@ -271,6 +272,9 @@ private boolean shouldRun(long electionTerm) {
 
   private ResultAndTerm submitRequestAndWaitResult(Phase phase, 
RaftConfigurationImpl conf, long electionTerm)
       throws InterruptedException {
+    if (!conf.containsInConf(server.getId()) && phase == Phase.ELECTION) {

Review comment:
       We should fix the unit tests but not adding the phase check here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to