Xushaohong commented on pull request #560: URL: https://github.com/apache/ratis/pull/560#issuecomment-994595809
I reviewed the failure UT of testRemovePeers. The fault is due to after removing the peers out of the conf, the division which should quit the raft group will become a candidate and start the election. During the prevote process, originally it will send out the request and then the other peers should send back ```should shutdown``` to turn this server down. But for our case, we just return ```new ResultAndTerm(Result.NOT_IN_CONF)```, and won't go to the SHUTDOWN branch. @szetszwo Shall we move up the line ```case NOT_IN_CONF:``` above ``` case SHUTDOWN ``` or still use my original phase check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
