SzyWilliam commented on code in PR #655:
URL: https://github.com/apache/ratis/pull/655#discussion_r890711657
##########
ratis-proto/src/main/proto/Grpc.proto:
##########
@@ -44,7 +44,7 @@ service RaftServerProtocolService {
returns(stream ratis.common.AppendEntriesReplyProto) {}
rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
- returns(ratis.common.InstallSnapshotReplyProto) {}
+ returns(stream ratis.common.InstallSnapshotReplyProto) {}
Review Comment:
I think it is a bug when using GRPC as communication protocol and involves
multiple snapshot chunks. The handler of InstallSnapshot is implemented
bidirectional-streaming, but the proto is declaimed client-streaming. The
mismatch will cause the leader received a HTTP RST CANCEL for the last
installSnapshot request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
