szetszwo commented on code in PR #655:
URL: https://github.com/apache/ratis/pull/655#discussion_r891641082
##########
ratis-proto/src/main/proto/Grpc.proto:
##########
@@ -44,7 +44,7 @@ service RaftServerProtocolService {
returns(stream ratis.common.AppendEntriesReplyProto) {}
rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
- returns(ratis.common.InstallSnapshotReplyProto) {}
+ returns(stream ratis.common.InstallSnapshotReplyProto) {}
Review Comment:
I agree that this is a bug. If it is an incompatible change, we still have
to document it even for a bug since it will break existing, working
applications. Currently, applications with single InstallSnapshotRequestProto
are working.
Indeed, it may not be incompatible. Could you test it if an old server
(without `stream`) can talk to a new server (with `stream`) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
