szetszwo commented on code in PR #561:
URL: https://github.com/apache/ratis/pull/561#discussion_r909078377
##########
ratis-common/src/main/java/org/apache/ratis/util/LifeCycle.java:
##########
@@ -100,8 +100,8 @@ static void put(State key, Map<State, List<State>> map,
State... values) {
put(PAUSING, predecessors, RUNNING);
put(PAUSED, predecessors, PAUSING);
put(EXCEPTION, predecessors, STARTING, PAUSING, RUNNING);
- put(CLOSING, predecessors, STARTING, RUNNING, PAUSING, PAUSED,
EXCEPTION);
- put(CLOSED, predecessors, NEW, CLOSING);
+ put(CLOSING, predecessors, NEW, STARTING, RUNNING, PAUSING, PAUSED,
EXCEPTION);
+ put(CLOSED, predecessors, CLOSING);
Review Comment:
@ChenSammi , as stated in the javadoc, NEW means that the machine is newly
created and holds zero resource so that it can be transit to CLOSED immediately.
BTW, we should not change LifeCycle since it is used in many places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
