szetszwo commented on code in PR #561:
URL: https://github.com/apache/ratis/pull/561#discussion_r911635769
##########
ratis-common/src/main/java/org/apache/ratis/util/LifeCycle.java:
##########
@@ -100,8 +100,8 @@ static void put(State key, Map<State, List<State>> map,
State... values) {
put(PAUSING, predecessors, RUNNING);
put(PAUSED, predecessors, PAUSING);
put(EXCEPTION, predecessors, STARTING, PAUSING, RUNNING);
- put(CLOSING, predecessors, STARTING, RUNNING, PAUSING, PAUSED,
EXCEPTION);
- put(CLOSED, predecessors, NEW, CLOSING);
+ put(CLOSING, predecessors, NEW, STARTING, RUNNING, PAUSING, PAUSED,
EXCEPTION);
+ put(CLOSED, predecessors, CLOSING);
Review Comment:
That's is a good point. RaftStorageImpl should not grab the LOCK in the
constructor. Let me see how to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
