szetszwo commented on code in PR #658:
URL: https://github.com/apache/ratis/pull/658#discussion_r913202156
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftConfigurationImpl.java:
##########
@@ -252,7 +252,7 @@ boolean hasNoChange(Collection<RaftPeer> newMembers,
Collection<RaftPeer> newLis
if (inConf == null) {
return false;
}
- if (!inConf.getRaftPeerProto().equals(peer.getRaftPeerProto())) {
+ if (inConf.getPriority() != peer.getPriority()) {
Review Comment:
I see now. The hostnames could be different
- inConf:
```
id: "s0"
address: "localhost:59232"
dataStreamAddress: "localhost:59235"
clientAddress: "localhost:59234"
adminAddress: "localhost:59233"
```
- peer :
```
id: "s0"
address: "0.0.0.0:59232"
clientAddress: "0.0.0.0:59234"
adminAddress: "0.0.0.0:59233"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
