codings-dan commented on code in PR #658:
URL: https://github.com/apache/ratis/pull/658#discussion_r913331852
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftConfigurationImpl.java:
##########
@@ -252,7 +252,7 @@ boolean hasNoChange(Collection<RaftPeer> newMembers,
Collection<RaftPeer> newLis
if (inConf == null) {
return false;
}
- if (!inConf.getRaftPeerProto().equals(peer.getRaftPeerProto())) {
+ if (inConf.getPriority() != peer.getPriority()) {
Review Comment:
@szetszwo Yean, the hostname could be different, so I only compare the
priority.
> We should think about how to support updating hostnames and ports
I will try, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
