szetszwo commented on code in PR #674:
URL: https://github.com/apache/ratis/pull/674#discussion_r916151232
##########
pom.xml:
##########
@@ -769,6 +769,7 @@
<configuration>
<configLocation>dev-support/checkstyle.xml</configLocation>
<failOnViolation>false</failOnViolation>
+ <includeTestSourceDirectory>true</includeTestSourceDirectory>
Review Comment:
@leo65535 , thanks for working on this. Fixing the checkstyle warnings in
test is good. However, let's don't run checkstyle for the tests. We should
focus more on the main code instead of spending too much energy on the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
